From: Vishal Verma <vishal.l.verma@intel.com>
Date: Tue, 7 Nov 2017 22:48:21 +0000 (-0700)
Subject: tools/testing/nvdimm: stricter bounds checking for error injection commands
X-Git-Tag: v4.15-rc1~71^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=41cb3301c04d7f0b046ed296a34ef261c456dde8;p=thirdparty%2Fkernel%2Flinux.git

tools/testing/nvdimm: stricter bounds checking for error injection commands

Ensure that the in/out sizes passed in the nd_cmd_package are sane for
the fixed output size commands (i.e. inject error and clear injected
error).

Reported-by: Dariusz Dokupil <dariusz.dokupil@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---

diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c
index 79c5cb23693f3..edab68c2e2215 100644
--- a/tools/testing/nvdimm/test/nfit.c
+++ b/tools/testing/nvdimm/test/nfit.c
@@ -488,7 +488,7 @@ static int nfit_test_cmd_ars_error_inject(struct nfit_test *t,
 {
 	int rc;
 
-	if (buf_len < sizeof(*err_inj)) {
+	if (buf_len != sizeof(*err_inj)) {
 		rc = -EINVAL;
 		goto err;
 	}
@@ -519,7 +519,7 @@ static int nfit_test_cmd_ars_inject_clear(struct nfit_test *t,
 {
 	int rc;
 
-	if (buf_len < sizeof(*err_clr)) {
+	if (buf_len != sizeof(*err_clr)) {
 		rc = -EINVAL;
 		goto err;
 	}