From: Denton Liu Date: Tue, 7 Jul 2020 22:08:07 +0000 (-0400) Subject: t9400: don't use test_must_fail with cvs X-Git-Tag: v2.29.0-rc0~213^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=41feac6f74719922bcc0bd44683518a6d6a8a943;p=thirdparty%2Fgit.git t9400: don't use test_must_fail with cvs We are using `test_must_fail cvs` to test that the cvs command fails as expected. However, test_must_fail() is used to ensure that commands fail in an expected way, not due to something like a segv. Since we are not in the business of verifying the sanity of the external world, replace `test_must_fail cvs` with `! cvs` and assume that the cvs command does not die unexpectedly. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano --- diff --git a/t/t9400-git-cvsserver-server.sh b/t/t9400-git-cvsserver-server.sh index a5e5dca753..4a46f31c41 100755 --- a/t/t9400-git-cvsserver-server.sh +++ b/t/t9400-git-cvsserver-server.sh @@ -603,7 +603,7 @@ test_expect_success 'cvs server does not run with vanilla git-shell' ' cd cvswork && CVS_SERVER=$WORKDIR/remote-cvs && export CVS_SERVER && - test_must_fail cvs log merge + ! cvs log merge ) '