From: Mike Frysinger <vapier@gentoo.org>
Date: Sun, 7 Jan 2024 05:23:41 +0000 (-0500)
Subject: sim: sh: avoid left shifting negative values
X-Git-Tag: binutils-2_42~203
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4223df94e038c653eab6cb39928184c3fcb2575f;p=thirdparty%2Fbinutils-gdb.git

sim: sh: avoid left shifting negative values

We just want to create a bitmask here, so cast the mask to unsigned
to avoid left shifting a negative value which is undefined behavior.
---

diff --git a/sim/sh/gencode.c b/sim/sh/gencode.c
index c121d53bb40..8246e89432f 100644
--- a/sim/sh/gencode.c
+++ b/sim/sh/gencode.c
@@ -2350,7 +2350,7 @@ static op ppi_tab[] =
     "  res = 31;",
     "do",
     "  {",
-    "    if (Sx & ~0 << i)",
+    "    if (Sx & ((unsigned)~0 << i))",
     "      {",
     "        res -= i;",
     "        Sx >>= i;",
@@ -2373,7 +2373,7 @@ static op ppi_tab[] =
     "res = 31;",
     "do",
     "  {",
-    "    if (Sy & ~0 << i)",
+    "    if (Sy & ((unsigned)~0 << i))",
     "      {",
     "        res -= i;",
     "        Sy >>= i;",