From: Gabor Juhos Date: Wed, 14 May 2025 19:18:38 +0000 (+0200) Subject: pinctrl: armada-37xx: propagate error from armada_37xx_pmx_set_by_name() X-Git-Tag: v6.16-rc1~113^2~6^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4229c28323db141eda69cb99427be75d3edba071;p=thirdparty%2Fkernel%2Flinux.git pinctrl: armada-37xx: propagate error from armada_37xx_pmx_set_by_name() The regmap_update_bits() function can fail, so propagate its error up to the stack instead of silently ignoring that. Signed-off-by: Imre Kaloz Reviewed-by: Andrew Lunn Signed-off-by: Gabor Juhos Link: https://lore.kernel.org/20250514-pinctrl-a37xx-fixes-v2-7-07e9ac1ab737@gmail.com Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 18c6c5026b26c..f35bf0cd98c97 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c @@ -358,9 +358,7 @@ static int armada_37xx_pmx_set_by_name(struct pinctrl_dev *pctldev, val = grp->val[func]; - regmap_update_bits(info->regmap, reg, mask, val); - - return 0; + return regmap_update_bits(info->regmap, reg, mask, val); } static int armada_37xx_pmx_set(struct pinctrl_dev *pctldev,