From: Peter Seiderer Date: Wed, 19 Feb 2025 08:45:27 +0000 (+0100) Subject: net: pktgen: fix access outside of user given buffer in pktgen_thread_write() X-Git-Tag: v6.15-rc1~160^2~261^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=425e64440ad0a2f03bdaf04be0ae53dededbaa77;p=thirdparty%2Fkernel%2Flinux.git net: pktgen: fix access outside of user given buffer in pktgen_thread_write() Honour the user given buffer size for the strn_len() calls (otherwise strn_len() will access memory outside of the user given buffer). Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman Link: https://patch.msgid.link/20250219084527.20488-8-ps.report@gmx.net Signed-off-by: Jakub Kicinski --- diff --git a/net/core/pktgen.c b/net/core/pktgen.c index f6e35ba035c7c..55064713223ec 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -1900,8 +1900,8 @@ static ssize_t pktgen_thread_write(struct file *file, i = len; /* Read variable name */ - - len = strn_len(&user_buffer[i], sizeof(name) - 1); + max = min(sizeof(name) - 1, count - i); + len = strn_len(&user_buffer[i], max); if (len < 0) return len; @@ -1931,7 +1931,8 @@ static ssize_t pktgen_thread_write(struct file *file, if (!strcmp(name, "add_device")) { char f[32]; memset(f, 0, 32); - len = strn_len(&user_buffer[i], sizeof(f) - 1); + max = min(sizeof(f) - 1, count - i); + len = strn_len(&user_buffer[i], max); if (len < 0) { ret = len; goto out;