From: Azeem Shaikh Date: Mon, 10 Jul 2023 01:17:48 +0000 (+0000) Subject: acct: replace all non-returning strlcpy with strscpy X-Git-Tag: v6.6-rc1~155^2~74 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4264be505d9f3657de9626f551099e595b2ae7fe;p=thirdparty%2Flinux.git acct: replace all non-returning strlcpy with strscpy strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] https://github.com/KSPP/linux/issues/89 Link: https://lkml.kernel.org/r/20230710011748.3538624-1-azeemshaikh38@gmail.com Signed-off-by: Azeem Shaikh Cc: Kees Cook Signed-off-by: Andrew Morton --- diff --git a/kernel/acct.c b/kernel/acct.c index 010667ce60801..10f769e13f724 100644 --- a/kernel/acct.c +++ b/kernel/acct.c @@ -445,7 +445,7 @@ static void fill_ac(acct_t *ac) memset(ac, 0, sizeof(acct_t)); ac->ac_version = ACCT_VERSION | ACCT_BYTEORDER; - strlcpy(ac->ac_comm, current->comm, sizeof(ac->ac_comm)); + strscpy(ac->ac_comm, current->comm, sizeof(ac->ac_comm)); /* calculate run_time in nsec*/ run_time = ktime_get_ns();