From: Victor Stinner <vstinner@python.org>
Date: Wed, 24 May 2023 08:29:35 +0000 (+0200)
Subject: Fix test_importlib.test_side_effect_import() (#104840)
X-Git-Tag: v3.13.0a1~2069
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=426950993f6a39cdf3f6a3333ac8b518833c7e61;p=thirdparty%2FPython%2Fcpython.git

Fix test_importlib.test_side_effect_import() (#104840)

Wait until the thread spawn by the import completes to avoid dangling
threads. With this fix, the following command no longer fails:

./python -m test --fail-env-changed test_importlib -m test_side_effect_import -F -j20
---

diff --git a/Lib/test/test_importlib/test_threaded_import.py b/Lib/test/test_importlib/test_threaded_import.py
index 85c3032aed53..68de4a66f3c7 100644
--- a/Lib/test/test_importlib/test_threaded_import.py
+++ b/Lib/test/test_importlib/test_threaded_import.py
@@ -238,7 +238,8 @@ class ThreadedImportTests(unittest.TestCase):
         self.addCleanup(forget, TESTFN)
         self.addCleanup(rmtree, '__pycache__')
         importlib.invalidate_caches()
-        __import__(TESTFN)
+        with threading_helper.wait_threads_exit():
+            __import__(TESTFN)
         del sys.modules[TESTFN]
 
     def test_concurrent_futures_circular_import(self):