From: Paul Eggert <eggert@cs.ucla.edu>
Date: Mon, 12 May 2025 00:25:30 +0000 (-0700)
Subject: factor: omit incorrect affirms in mulredc2
X-Git-Tag: v9.8~333
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4274ff6eee1bd49352e4381cf8e50b3ea2006013;p=thirdparty%2Fcoreutils.git

factor: omit incorrect affirms in mulredc2

* src/factor.c (mulredc2): Remove two ‘affirm’ calls that didn’t
match the accompanying comment, and one of which has a false
positive if UINTMAX_WIDTH == 128 and we factor 2**128 + 1.
---

diff --git a/src/factor.c b/src/factor.c
index 1f43ccafe8..d07ab9419c 100644
--- a/src/factor.c
+++ b/src/factor.c
@@ -975,8 +975,6 @@ mulredc2 (uintmax_t *r1p,
   uintmax_t r1, r0, q, p1, t1, t0, s1, s0;
   MAYBE_UNUSED uintmax_t p0;
   mi = -mi;
-  affirm ((a1 >> (W_TYPE_SIZE - 1)) == 0);
-  affirm ((b1 >> (W_TYPE_SIZE - 1)) == 0);
   affirm ((m1 >> (W_TYPE_SIZE - 1)) == 0);
 
   /* First compute a0 * <b1, b0> B^{-1}