From: Derrick Stolee <dstolee@microsoft.com>
Date: Mon, 17 May 2021 12:22:17 +0000 (+0000)
Subject: sparse-index: fix uninitialized jump
X-Git-Tag: v2.32.0-rc1~4^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4279cb1c6e4e5b60b099833d8e3debba4ac35eba;p=thirdparty%2Fgit.git

sparse-index: fix uninitialized jump

While testing the sparse-index, I verified a test with --valgrind and it
complained about an uninitialized value being used in a jump in the
path_matches_pattern_list() method. The line was this one:

	if (*dtype == DT_UNKNOWN)

In the call stack, the culprit was the initialization of the dtype
variable in convert_to_sparse_rec().

Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/sparse-index.c b/sparse-index.c
index 6f21397e2e..ca839e4381 100644
--- a/sparse-index.c
+++ b/sparse-index.c
@@ -34,7 +34,7 @@ static int convert_to_sparse_rec(struct index_state *istate,
 	int i, can_convert = 1;
 	int start_converted = num_converted;
 	enum pattern_match_result match;
-	int dtype;
+	int dtype = DT_UNKNOWN;
 	struct strbuf child_path = STRBUF_INIT;
 	struct pattern_list *pl = istate->sparse_checkout_patterns;