From: Willy Tarreau <w@1wt.eu>
Date: Tue, 4 Jun 2019 14:02:26 +0000 (+0200)
Subject: BUILD: tools: do not use the weak attribute for trace() on obsolete linkers
X-Git-Tag: v2.0-dev6~64
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=42a6621d3057e03653233076c5d06c079dee5c22;p=thirdparty%2Fhaproxy.git

BUILD: tools: do not use the weak attribute for trace() on obsolete linkers

The default dummy trace() function is marked weak in order to be easily
replaced at link time. Some linkers are having issues with the weak
attribute, so let's not mark it on these linkers. They will simply not
be able to build with TRACE=1, which is no big deal since it's only used
by developers.
---

diff --git a/src/standard.c b/src/standard.c
index 1c2e5099c0..1dec56123c 100644
--- a/src/standard.c
+++ b/src/standard.c
@@ -4298,7 +4298,9 @@ int parse_dotted_uints(const char *str, unsigned int **nums, size_t *sz)
 }
 
 /* do nothing, just a placeholder for debugging calls, the real one is in trace.c */
+#ifndef USE_OBSOLETE_LINKER
 __attribute__((weak,format(printf, 1, 2)))
+#endif
 void trace(char *msg, ...)
 {
 }