From: Patrick Steinhardt <ps@pks.im>
Date: Thu, 5 Sep 2024 10:09:01 +0000 (+0200)
Subject: remote: fix leak in reachability check of a remote-tracking ref
X-Git-Tag: v2.47.0-rc0~28^2~13
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=42c153e1c06fcfea8446f11bf3fc3bcf9ea25867;p=thirdparty%2Fgit.git

remote: fix leak in reachability check of a remote-tracking ref

In `check_if_includes_upstream()` we retrieve the local ref
corresponding to a remote-tracking ref we want to check reachability
for. We never free that local ref and thus cause a memory leak. Fix
this.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/remote.c b/remote.c
index 8d666c1641..e11b03a075 100644
--- a/remote.c
+++ b/remote.c
@@ -2731,6 +2731,7 @@ static void check_if_includes_upstream(struct ref *remote)
 
 	if (is_reachable_in_reflog(local->name, remote) <= 0)
 		remote->unreachable = 1;
+	free_one_ref(local);
 }
 
 static void apply_cas(struct push_cas_option *cas,
diff --git a/t/t5533-push-cas.sh b/t/t5533-push-cas.sh
index cba26a872d..6365d99777 100755
--- a/t/t5533-push-cas.sh
+++ b/t/t5533-push-cas.sh
@@ -5,6 +5,7 @@ test_description='compare & swap push force/delete safety'
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 setup_srcdst_basic () {