From: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Thu, 14 Jun 2018 15:51:41 +0000 (+0200)
Subject: chardev: remove qemu_chr_fe_read_all() counter
X-Git-Tag: v3.1.0-rc0~70^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=43182856c5a576f5db5f40768972a19f187a789e;p=thirdparty%2Fqemu.git

chardev: remove qemu_chr_fe_read_all() counter

There is no obvious reason to have a loop counter. This limits from
reading several megabytes large buffers in one go, since socket
read/write usually have a limit.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/chardev/char-fe.c b/chardev/char-fe.c
index b1f228e8b57..f158f158f81 100644
--- a/chardev/char-fe.c
+++ b/chardev/char-fe.c
@@ -56,7 +56,7 @@ int qemu_chr_fe_write_all(CharBackend *be, const uint8_t *buf, int len)
 int qemu_chr_fe_read_all(CharBackend *be, uint8_t *buf, int len)
 {
     Chardev *s = be->chr;
-    int offset = 0, counter = 10;
+    int offset = 0;
     int res;
 
     if (!s || !CHARDEV_GET_CLASS(s)->chr_sync_read) {
@@ -88,10 +88,6 @@ int qemu_chr_fe_read_all(CharBackend *be, uint8_t *buf, int len)
         }
 
         offset += res;
-
-        if (!counter--) {
-            break;
-        }
     }
 
     if (qemu_chr_replay(s) && replay_mode == REPLAY_MODE_RECORD) {