From: Richard Sandiford Date: Mon, 12 Dec 2011 15:18:24 +0000 (+0000) Subject: re PR tree-optimization/50873 (The fix to PR50730 causes gcc.c-torture/unsorted/dilay... X-Git-Tag: releases/gcc-4.7.0~1602 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=431e1124edfc6ac99951af5286190d92c983354d;p=thirdparty%2Fgcc.git re PR tree-optimization/50873 (The fix to PR50730 causes gcc.c-torture/unsorted/dilayout.c to ICE) gcc/ PR middle-end/50873 * optabs.c (maybe_legitimize_operand_same_code): Use copy_to_mode_reg instead of force_reg. Do nothing if the address is already a non-virtual pseudo register. From-SVN: r182244 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 17be451977da..d02c8df3eb20 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2011-12-12 Richard Sandiford + + PR middle-end/50873 + * optabs.c (maybe_legitimize_operand_same_code): Use copy_to_mode_reg + instead of force_reg. Do nothing if the address is already a + non-virtual pseudo register. + 2011-12-12 Torvald Riegel * gimplify.c (voidify_wrapper_expr): Add default handling for diff --git a/gcc/optabs.c b/gcc/optabs.c index 2c3a6405ab9c..0d5cd73c3a24 100644 --- a/gcc/optabs.c +++ b/gcc/optabs.c @@ -8242,24 +8242,31 @@ maybe_legitimize_operand_same_code (enum insn_code icode, unsigned int opno, return true; /* If the operand is a memory whose address has no side effects, - try forcing the address into a register. The check for side - effects is important because force_reg cannot handle things - like auto-modified addresses. */ - if (insn_data[(int) icode].operand[opno].allows_mem - && MEM_P (op->value) - && !side_effects_p (XEXP (op->value, 0))) - { - rtx addr, mem, last; - - last = get_last_insn (); - addr = force_reg (Pmode, XEXP (op->value, 0)); - mem = replace_equiv_address (op->value, addr); - if (insn_operand_matches (icode, opno, mem)) + try forcing the address into a non-virtual pseudo register. + The check for side effects is important because copy_to_mode_reg + cannot handle things like auto-modified addresses. */ + if (insn_data[(int) icode].operand[opno].allows_mem && MEM_P (op->value)) + { + rtx addr, mem; + + mem = op->value; + addr = XEXP (mem, 0); + if (!(REG_P (addr) && REGNO (addr) > LAST_VIRTUAL_REGISTER) + && !side_effects_p (addr)) { - op->value = mem; - return true; + rtx last; + enum machine_mode mode; + + last = get_last_insn (); + mode = targetm.addr_space.address_mode (MEM_ADDR_SPACE (mem)); + mem = replace_equiv_address (mem, copy_to_mode_reg (mode, addr)); + if (insn_operand_matches (icode, opno, mem)) + { + op->value = mem; + return true; + } + delete_insns_since (last); } - delete_insns_since (last); } return false;