From: Chuck Lever Date: Mon, 19 Aug 2019 22:51:49 +0000 (-0400) Subject: xprtrdma: Optimize rpcrdma_post_recvs() X-Git-Tag: v5.4-rc1~40^2~31 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=435eba4ae0692e2f3d62988f8648efd65c935b6a;p=thirdparty%2Fkernel%2Flinux.git xprtrdma: Optimize rpcrdma_post_recvs() Micro-optimization: In rpcrdma_post_recvs, since commit e340c2d6ef2a ("xprtrdma: Reduce the doorbell rate (Receive)"), the common case is to return without doing anything. Found with perf. Signed-off-by: Chuck Lever Signed-off-by: Anna Schumaker --- diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c index db90083ed35b6..ac2abf4578b94 100644 --- a/net/sunrpc/xprtrdma/verbs.c +++ b/net/sunrpc/xprtrdma/verbs.c @@ -1465,7 +1465,7 @@ rpcrdma_post_recvs(struct rpcrdma_xprt *r_xprt, bool temp) count = 0; needed = buf->rb_credits + (buf->rb_bc_srv_max_requests << 1); - if (ep->rep_receive_count > needed) + if (likely(ep->rep_receive_count > needed)) goto out; needed -= ep->rep_receive_count; if (!temp)