From: Ævar Arnfjörð Bjarmason Date: Mon, 10 Oct 2022 20:38:00 +0000 (-0700) Subject: CodingGuidelines: recommend against unportable C99 struct syntax X-Git-Tag: v2.39.0-rc0~98^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=438c2f859b2c8c01c57a6969ec5858c0253cfa69;p=thirdparty%2Fgit.git CodingGuidelines: recommend against unportable C99 struct syntax Per 33665d98e6b (reftable: make assignments portable to AIX xlc v12.01, 2022-03-28) forms like ".a.b = *c" can be replaced by using ".a = { .b = *c }" instead. We'll probably allow these sooner than later, but since the workaround is trivial let's note it among the C99 features we'd like to hold off on for now. Signed-off-by: Ævar Arnfjörð Bjarmason Signed-off-by: Junio C Hamano --- diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index 9598b45f7e..1d95a142b2 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -242,6 +242,11 @@ For C programs: printf("%"PRIuMAX, (uintmax_t)v). These days the MSVC version we rely on supports %z, but the C library used by MinGW does not. + . Shorthand like ".a.b = *c" in struct initializations is known to + trip up an older IBM XLC version, use ".a = { .b = *c }" instead. + See the 33665d98 (reftable: make assignments portable to AIX xlc + v12.01, 2022-03-28). + - Variables have to be declared at the beginning of the block, before the first statement (i.e. -Wdeclaration-after-statement).