From: Jinjie Ruan Date: Fri, 6 Sep 2024 02:39:56 +0000 (+0800) Subject: spi: atmel-quadspi: Undo runtime PM changes at driver exit time X-Git-Tag: v6.12-rc1~48^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=438efb23f9581659495b85f1f6c7d5946200660c;p=thirdparty%2Fkernel%2Flinux.git spi: atmel-quadspi: Undo runtime PM changes at driver exit time It's important to undo pm_runtime_use_autosuspend() with pm_runtime_dont_use_autosuspend() at driver exit time unless driver initially enabled pm_runtime with devm_pm_runtime_enable() (which handles it for you). Hence, call pm_runtime_dont_use_autosuspend() at driver exit time to fix it. Fixes: 4a2f83b7f780 ("spi: atmel-quadspi: add runtime pm support") Signed-off-by: Jinjie Ruan Link: https://patch.msgid.link/20240906023956.1004440-1-ruanjinjie@huawei.com Signed-off-by: Mark Brown --- diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c index 936d578694931..9b7aeef6ce999 100644 --- a/drivers/spi/atmel-quadspi.c +++ b/drivers/spi/atmel-quadspi.c @@ -721,6 +721,7 @@ static void atmel_qspi_remove(struct platform_device *pdev) clk_unprepare(aq->pclk); pm_runtime_disable(&pdev->dev); + pm_runtime_dont_use_autosuspend(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); }