From: Bruce Momjian <bruce@momjian.us>
Date: Thu, 21 Jul 2011 21:12:35 +0000 (-0400)
Subject: In pg_upgrade, add C comment about why we don't try to do shared file
X-Git-Tag: REL9_2_BETA1~1366
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=43aa40e1551b9e8d30b376de6d6a9b976ae54332;p=thirdparty%2Fpostgresql.git

In pg_upgrade, add C comment about why we don't try to do shared file
writes for logging.
---

diff --git a/contrib/pg_upgrade/pg_upgrade.h b/contrib/pg_upgrade/pg_upgrade.h
index df884bd684b..6def748ae81 100644
--- a/contrib/pg_upgrade/pg_upgrade.h
+++ b/contrib/pg_upgrade/pg_upgrade.h
@@ -207,6 +207,10 @@ typedef struct
 	 * because it is being used by another process." so we have to send all
 	 * other output to 'nul'.  Therefore, we set this to DEVNULL on Win32, and
 	 * it equals 'filename' on all other platforms.
+	 *
+	 * We could use the Windows pgwin32_open() flags to allow shared file
+	 * writes but is unclear how all other tools would use those flags, so
+	 * we just avoid it and log a little less on Windows.
 	 */
 	char	   *filename2;
 	FILE	   *fd;				/* log FILE */