From: Kohei Yoshino <kohei.yoshino@gmail.com>
Date: Wed, 3 Apr 2019 19:32:16 +0000 (-0400)
Subject: Bug 1281200 - New show_bug.cgi view should have an option to have fields editable... 
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=43b147f40856e2e21d1d0f8e5c3ca120a92eaa1f;p=thirdparty%2Fbugzilla.git

Bug 1281200 - New show_bug.cgi view should have an option to have fields editable by default.
---

diff --git a/extensions/BugModal/template/en/default/bug_modal/edit.html.tmpl b/extensions/BugModal/template/en/default/bug_modal/edit.html.tmpl
index c218ab5e0..12d741ff0 100644
--- a/extensions/BugModal/template/en/default/bug_modal/edit.html.tmpl
+++ b/extensions/BugModal/template/en/default/bug_modal/edit.html.tmpl
@@ -323,6 +323,10 @@
         <button type="button" id="action-menu-btn" aria-haspopup="true" aria-label="Actions Menu"
           aria-expanded="false" aria-controls="action-menu" class="dropdown-button minor">&#9662;</button>
         <ul class="dropdown-content left" id="action-menu" role="menu" style="display:none;">
+          <li role="presentation">
+            <a id="action-enable-perm-edit" role="menuitemcheckbox" tabindex="-1">Always Enable Edit Mode</a>
+          </li>
+          <li role="separator"></li>
           <li role="presentation">
             <a id="action-reset" role="menuitem" tabindex="-1">Reset Sections</a>
           </li>
diff --git a/extensions/BugModal/web/bug_modal.js b/extensions/BugModal/web/bug_modal.js
index ed3b1afe2..a3610dbed 100644
--- a/extensions/BugModal/web/bug_modal.js
+++ b/extensions/BugModal/web/bug_modal.js
@@ -81,8 +81,13 @@ $(function() {
 
     // restore edit mode after navigating back
     function restoreEditMode() {
-        if (!$('#editing').val())
+        if (!$('#editing').val()) {
+            if (localStorage.getItem('modal-perm-edit-mode') === 'true') {
+                $('#mode-btn').click();
+                $('#action-enable-perm-edit').attr('aria-checked', 'true');
+            }
             return;
+        }
         $('.module')
             .each(function() {
                 slide_module($(this), 'hide', true);
@@ -388,6 +393,15 @@ $(function() {
 
     // action button actions
 
+    // enable perm edit mode
+    $('#action-enable-perm-edit')
+        .click(function(event) {
+            event.preventDefault();
+            const enabled = $(this).attr('aria-checked') !== 'true';
+            $(this).attr('aria-checked', enabled);
+            localStorage.setItem('modal-perm-edit-mode', enabled);
+        });
+
     // reset
     $('#action-reset')
         .click(function(event) {
diff --git a/skins/standard/global.css b/skins/standard/global.css
index 34915bb7b..5964b5e58 100644
--- a/skins/standard/global.css
+++ b/skins/standard/global.css
@@ -1971,12 +1971,12 @@ a.controller {
   list-style: none;
 }
 
-.dropdown-content [role="menuitem"],
+.dropdown-content [role^="menuitem"],
 .dropdown-content [role="option"],
 .dropdown-content li > div {
   display: block;
   box-sizing: border-box;
-  padding: 2px 16px;
+  padding: 2px 8px 2px 24px;
   width: 100%;
   color: #555;
   line-height: 1.5;
@@ -1984,17 +1984,17 @@ a.controller {
   background: none transparent;
 }
 
-.dropdown-content [role="menuitem"],
+.dropdown-content [role^="menuitem"],
 .dropdown-content [role="option"] {
   outline: 0;
   text-decoration: none;
   cursor: pointer;
 }
 
-.dropdown-content [role="menuitem"]:hover,
-.dropdown-content [role="menuitem"]:focus,
-.dropdown-content [role="menuitem"]:active,
-.dropdown-content [role="menuitem"].active,
+.dropdown-content [role^="menuitem"]:hover,
+.dropdown-content [role^="menuitem"]:focus,
+.dropdown-content [role^="menuitem"]:active,
+.dropdown-content [role^="menuitem"].active,
 .dropdown-content [role="option"]:hover,
 .dropdown-content [role="option"]:focus,
 .dropdown-content [role="option"]:active,
@@ -2003,7 +2003,7 @@ a.controller {
   background-color: rgba(0, 0, 0, .1) !important;
 }
 
-.dropdown-content button[role="menuitem"] {
+.dropdown-content button[role^="menuitem"] {
   -moz-appearance: none;
   -webkit-appearance: none;
   appearance: none;
@@ -2015,10 +2015,20 @@ a.controller {
   text-align: left;
 }
 
-.dropdown-content button[role="menuitem"]::-moz-focus-inner {
+.dropdown-content button[role^="menuitem"]::-moz-focus-inner {
   border: 0;
 }
 
+.dropdown-content [role="menuitemcheckbox"][aria-checked="true"]::before {
+  display: inline-block;
+  content: '\E5CA';
+  font-size: 18px;
+  line-height: 1;
+  font-family: 'Material Icons';
+  vertical-align: text-bottom;
+  text-indent: -20px;
+}
+
 .dropdown-content [role="separator"] {
   height: 0;
   margin: 4px 0 !important;