From: Ben Peart Date: Mon, 10 Sep 2018 16:29:29 +0000 (+0000) Subject: git-mv: allow submodules and fsmonitor to work together X-Git-Tag: v2.20.0-rc0~221^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=43f1180814f456ba5fb90a55c90766b5799bd1a7;p=thirdparty%2Fgit.git git-mv: allow submodules and fsmonitor to work together It was reported that GIT_FSMONITOR_TEST=$PWD/t7519/fsmonitor-all ./t7411-submodule-config.sh breaks as the fsmonitor data is out of sync with the state of the .gitmodules file. Update is_staging_gitmodules_ok() so that it no longer tells ie_match_stat() to ignore refreshing the fsmonitor data. Reported-by: Ævar Arnfjörð Bjarmason Helped-by: Stefan Beller Signed-off-by: Ben Peart Signed-off-by: Junio C Hamano --- diff --git a/submodule.c b/submodule.c index 939d6870ec..1c6d4215f5 100644 --- a/submodule.c +++ b/submodule.c @@ -65,8 +65,7 @@ int is_staging_gitmodules_ok(struct index_state *istate) if ((pos >= 0) && (pos < istate->cache_nr)) { struct stat st; if (lstat(GITMODULES_FILE, &st) == 0 && - ie_match_stat(istate, istate->cache[pos], &st, - CE_MATCH_IGNORE_FSMONITOR) & DATA_CHANGED) + ie_match_stat(istate, istate->cache[pos], &st, 0) & DATA_CHANGED) return 0; }