From: dan <dan@noemail.net>
Date: Tue, 23 Feb 2010 10:56:15 +0000 (+0000)
Subject: Fix a segfault that can occur if a malloc fails in ATTACH in shared-cache mode.
X-Git-Tag: version-3.7.2~590^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=440ac39bc05282fdaef8cc8d386f9eba17f31ff6;p=thirdparty%2Fsqlite.git

Fix a segfault that can occur if a malloc fails in ATTACH in shared-cache mode.

FossilOrigin-Name: 875f8fa32708b8dbf314fd7056fac2fefdacfa36
---

diff --git a/manifest b/manifest
index 6e5969c25e..55720089d3 100644
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Removed\schecking\sof\ssome\scompile\soptions\sfrom\sthe\ssqlite3_compileopts()\sAPI.
-D 2010-02-23T05:17:52
+C Fix\sa\ssegfault\sthat\scan\soccur\sif\sa\smalloc\sfails\sin\sATTACH\sin\sshared-cache\smode.
+D 2010-02-23T10:56:16
 F Makefile.arm-wince-mingw32ce-gcc fcd5e9cd67fe88836360bb4f9ef4cb7f8e2fb5a0
 F Makefile.in c5827ead754ab32b9585487177c93bb00b9497b3
 F Makefile.linux-gcc d53183f4aa6a9192d249731c90dbdffbd2c68654
@@ -104,7 +104,7 @@ F sqlite3.1 6be1ad09113570e1fc8dcaff84c9b0b337db5ffc
 F sqlite3.pc.in ae6f59a76e862f5c561eb32a380228a02afc3cad
 F src/alter.c e6f4d11b1c0b23642fc46bac9abe0753c4294e05
 F src/analyze.c 55155f05ee9ab4ce33b7a4d19c449053f8935200
-F src/attach.c f6d33268019460724e4c57aeec543eaaa55d8310
+F src/attach.c 01fd6ce19ee1567fea8d647eaec7486588756d8f
 F src/auth.c 523da7fb4979469955d822ff9298352d6b31de34
 F src/backup.c b293534bc2df23c57668a585b17ee7faaaef0939
 F src/bitvec.c 06ad2c36a9c3819c0b9cbffec7b15f58d5d834e0
@@ -240,7 +240,7 @@ F test/async5.test f3592d79c84d6e83a5f50d3fd500445f7d97dfdf
 F test/attach.test ce9660e51768fab93cf129787be886c5d6c4fd81
 F test/attach2.test a295d2d7061adcee5884ef4a93c7c96a82765437
 F test/attach3.test bd9830bc3a0d22ed1310c9bff6896927937017dc
-F test/attachmalloc.test cf8cf17d183de357b1147a9baacbdfc85b940b61
+F test/attachmalloc.test 38d2da5fdaf09ba0add57296967a3061e5842584
 F test/auth.test 8f21c160a4562f54f27618e85bac869efcecbcaf
 F test/auth2.test 270baddc8b9c273682760cffba6739d907bd2882
 F test/auth3.test a4755e6a2a2fea547ffe63c874eb569e60a28eb5
@@ -791,7 +791,7 @@ F tool/speedtest2.tcl ee2149167303ba8e95af97873c575c3e0fab58ff
 F tool/speedtest8.c 2902c46588c40b55661e471d7a86e4dd71a18224
 F tool/speedtest8inst1.c 293327bc76823f473684d589a8160bde1f52c14e
 F tool/vdbe-compress.tcl d70ea6d8a19e3571d7ab8c9b75cba86d1173ff0f
-P 84c9756993caf82710a0905ed1987d144bc764fd
-R f5089208430b2ba4dd4063929e4e20e6
-U shaneh
-Z 9884f73578eca45685b3905c76fc5c0d
+P 833da702ff9bd99d62640756d80e094256efff5c
+R 266d27e76a2b37d15f5a03e24c556a22
+U dan
+Z 060e5b129e7fc7dc7958eb9fd3924fd7
diff --git a/manifest.uuid b/manifest.uuid
index 519435ec1f..2887d00aa7 100644
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-833da702ff9bd99d62640756d80e094256efff5c
\ No newline at end of file
+875f8fa32708b8dbf314fd7056fac2fefdacfa36
\ No newline at end of file
diff --git a/src/attach.c b/src/attach.c
index f4b9428c0f..b9a5bee695 100644
--- a/src/attach.c
+++ b/src/attach.c
@@ -147,8 +147,12 @@ static void attachFunc(
     sqlite3BtreeSecureDelete(aNew->pBt,
                              sqlite3BtreeSecureDelete(db->aDb[0].pBt,-1) );
   }
-  aNew->zName = sqlite3DbStrDup(db, zName);
   aNew->safety_level = 3;
+  aNew->zName = sqlite3DbStrDup(db, zName);
+  if( rc==SQLITE_OK && aNew->zName==0 ){
+    rc = SQLITE_NOMEM;
+  }
+
 
 #ifdef SQLITE_HAS_CODEC
   if( rc==SQLITE_OK ){
diff --git a/test/attachmalloc.test b/test/attachmalloc.test
index 30841cea76..cc506bee6a 100644
--- a/test/attachmalloc.test
+++ b/test/attachmalloc.test
@@ -60,4 +60,17 @@ do_malloc_test attachmalloc-2 -tclprep {
   ATTACH 'test2.db' AS db1;
 }
 
+set enable_shared_cache [sqlite3_enable_shared_cache 1]
+sqlite3 dbaux test2.db
+dbaux eval {SELECT * FROM sqlite_master}
+do_malloc_test attachmalloc-3 -sqlbody {
+  SELECT * FROM sqlite_master;
+  ATTACH 'test2.db' AS two;
+} -cleanup {
+  db eval { DETACH two }
+}
+dbaux close
+sqlite3_enable_shared_cache $enable_shared_cache
+
+
 finish_test