From: Andrew Dunstan Date: Mon, 3 Jul 2023 14:53:16 +0000 (-0400) Subject: Revert "Improve pg_basebackup long file name test Windows robustness" X-Git-Tag: REL_11_21~30 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4463a78460eed9d16a2f554a19de574a2fdda0af;p=thirdparty%2Fpostgresql.git Revert "Improve pg_basebackup long file name test Windows robustness" Version 12 and older are missing the required infrastructure. --- diff --git a/src/bin/pg_basebackup/t/010_pg_basebackup.pl b/src/bin/pg_basebackup/t/010_pg_basebackup.pl index dede83f398a..29d0ae0a42c 100644 --- a/src/bin/pg_basebackup/t/010_pg_basebackup.pl +++ b/src/bin/pg_basebackup/t/010_pg_basebackup.pl @@ -197,12 +197,8 @@ $node->command_fails( '-T with invalid format fails'); # Tar format doesn't support filenames longer than 100 bytes. -# Create the test file via a short name directory so it doesn't blow the -# Windows path limit. -my $lftmp = TestLib::tempdir_short; -dir_symlink "$pgdata", "$lftmp/pgdata"; my $superlongname = "superlongname_" . ("x" x 100); -my $superlongpath = "$lftmp/pgdata/$superlongname"; +my $superlongpath = "$pgdata/$superlongname"; open my $file, '>', "$superlongpath" or die "unable to create file $superlongpath"; @@ -210,7 +206,7 @@ close $file; $node->command_fails( [ 'pg_basebackup', '-D', "$tempdir/tarbackup_l1", '-Ft' ], 'pg_basebackup tar with long name fails'); -unlink "$superlongpath"; +unlink "$pgdata/$superlongname"; # The following tests test symlinks. Windows doesn't have symlinks, so # skip on Windows.