From: Kate Hsuan Date: Tue, 11 Feb 2025 05:02:40 +0000 (+0800) Subject: HID: Kconfig: Add LEDS_CLASS_MULTICOLOR dependency to HID_LOGITECH X-Git-Tag: v6.15-rc1~171^2~6^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4465f4fa21e0e54c10896db3ed49dbd5a9aad3fd;p=thirdparty%2Fkernel%2Flinux.git HID: Kconfig: Add LEDS_CLASS_MULTICOLOR dependency to HID_LOGITECH The test bot found an issue with building hid-lg-g15. All errors (new ones prefixed by >>): powerpc-linux-ld: drivers/hid/hid-lg-g15.o: in function `lg_g510_kbd_led_write': >> drivers/hid/hid-lg-g15.c:241:(.text+0x768): undefined reference to `led_mc_calc_color_components' powerpc-linux-ld: drivers/hid/hid-lg-g15.o: in function `lg_g15_register_led': >> drivers/hid/hid-lg-g15.c:686:(.text+0xa9c): undefined reference to `devm_led_classdev_multicolor_register_ext' Since multicolor LED APIs manage the keyboard backlight settings of hid-lg-g15, the LEDS_CLASS_MULTICOLOR dependency was added to HID_LOGITECH. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202502110032.VZ0J024X-lkp@intel.com/ Fixes: a3a064146c50 ("HID: hid-lg-g15: Use standard multicolor LED API") Signed-off-by: Kate Hsuan Signed-off-by: Jiri Kosina --- diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index b53eb569bd495..e8c542f012f69 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -601,6 +601,7 @@ config HID_LOGITECH tristate "Logitech devices" depends on USB_HID depends on LEDS_CLASS + depends on LEDS_CLASS_MULTICOLOR default !EXPERT help Support for Logitech devices that are not fully compliant with HID standard.