From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 7 Oct 2025 16:25:27 +0000 (+0200)
Subject: smb: client: Return directly after a failed genlmsg_new() in cifs_swn_send_register_m... 
X-Git-Tag: v6.18-rc1~18^2~14
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4468490251c0392e0c87a3f1c1c1585a89f6ffa6;p=thirdparty%2Flinux.git

smb: client: Return directly after a failed genlmsg_new() in cifs_swn_send_register_message()

MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Return directly after a call of the function “genlmsg_new” failed
  at the beginning.

* Delete the label “fail” which became unnecessary
  with this refactoring.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Steve French <stfrench@microsoft.com>
---

diff --git a/fs/smb/client/cifs_swn.c b/fs/smb/client/cifs_swn.c
index 35a3e73c19580..68a1f87c446d0 100644
--- a/fs/smb/client/cifs_swn.c
+++ b/fs/smb/client/cifs_swn.c
@@ -82,10 +82,8 @@ static int cifs_swn_send_register_message(struct cifs_swn_reg *swnreg)
 	int ret;
 
 	skb = genlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
-	if (skb == NULL) {
-		ret = -ENOMEM;
-		goto fail;
-	}
+	if (!skb)
+		return -ENOMEM;
 
 	hdr = genlmsg_put(skb, 0, 0, &cifs_genl_family, 0, CIFS_GENL_CMD_SWN_REGISTER);
 	if (hdr == NULL) {
@@ -172,7 +170,6 @@ static int cifs_swn_send_register_message(struct cifs_swn_reg *swnreg)
 nlmsg_fail:
 	genlmsg_cancel(skb, hdr);
 	nlmsg_free(skb);
-fail:
 	return ret;
 }