From: Arvind Yadav Date: Thu, 23 Nov 2017 15:55:29 +0000 (+0530) Subject: extcon: adc-jack: Fix platform_get_irq's error checking X-Git-Tag: v4.16-rc1~110^2~47^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=447641eb88287fa29971b076166397e3f4cce3dd;p=thirdparty%2Fkernel%2Flinux.git extcon: adc-jack: Fix platform_get_irq's error checking The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav Signed-off-by: Chanwoo Choi --- diff --git a/drivers/extcon/extcon-adc-jack.c b/drivers/extcon/extcon-adc-jack.c index 3877d86c746a8..18026354c332c 100644 --- a/drivers/extcon/extcon-adc-jack.c +++ b/drivers/extcon/extcon-adc-jack.c @@ -144,7 +144,7 @@ static int adc_jack_probe(struct platform_device *pdev) return err; data->irq = platform_get_irq(pdev, 0); - if (!data->irq) { + if (data->irq < 0) { dev_err(&pdev->dev, "platform_get_irq failed\n"); return -ENODEV; }