From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Fri, 28 May 2021 09:23:48 +0000 (+0200)
Subject: send-email: get rid of indirect object syntax
X-Git-Tag: v2.33.0-rc0~33^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=447ed29c0d414547914c23e92f8bb13fcf748f9b;p=thirdparty%2Fgit.git

send-email: get rid of indirect object syntax

Change indirect object syntax such as "new X ARGS" to
"X->new(ARGS)". This allows perl to see what "new" is at compile-time
without having loaded Term::ReadLine. This doesn't matter now, but
will in a subsequent commit when we start lazily loading it.

Let's do the same for the adjacent "FakeTerm" package for consistency,
even though we're not going to conditionally load it.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/git-send-email.perl b/git-send-email.perl
index 44dc3f6eb1..cc1027d877 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -194,11 +194,11 @@ my $repo = eval { Git->repository() };
 my @repo = $repo ? ($repo) : ();
 my $term = eval {
 	$ENV{"GIT_SEND_EMAIL_NOTTY"}
-		? new Term::ReadLine 'git-send-email', \*STDIN, \*STDOUT
-		: new Term::ReadLine 'git-send-email';
+		? Term::ReadLine->new('git-send-email', \*STDIN, \*STDOUT)
+		: Term::ReadLine->new('git-send-email');
 };
 if ($@) {
-	$term = new FakeTerm "$@: going non-interactive";
+	$term = FakeTerm->new("$@: going non-interactive");
 }
 
 # Behavior modification variables