From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Thu, 19 Dec 2024 15:34:18 +0000 (+0100)
Subject: CLEANUP: mux-quic: remove dead err label in qcc_build_frms()
X-Git-Tag: v3.2-dev2~25
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4490df57a6d6d603077c1ecbb69c67a07bc9e3d6;p=thirdparty%2Fhaproxy.git

CLEANUP: mux-quic: remove dead err label in qcc_build_frms()

STREAM frames emission in qcc_build_frms() has been splitted from
RESET_STREAM/STOP_SENDING into qcc_emit_rs_ss(). Now, the former cannot
fail, as such err label can be removed as it is unreachable.

This should be backported up to 3.1.

This should fix github issue #2824.
---

diff --git a/src/mux_quic.c b/src/mux_quic.c
index 611c5dba22..e3fa05cb48 100644
--- a/src/mux_quic.c
+++ b/src/mux_quic.c
@@ -2443,11 +2443,6 @@ static int qcc_build_frms(struct qcc *qcc, struct list *qcs_failed)
 
 	TRACE_LEAVE(QMUX_EV_QCC_SEND, qcc->conn);
 	return total;
-
- err:
-	qcc_clear_frms(qcc);
-	TRACE_DEVEL("leaving on error", QMUX_EV_QCC_SEND, qcc->conn);
-	return 0;
 }
 
 /* Proceed to sending. Loop through all available streams for the <qcc>