From: Petr Pavlu <petr.pavlu@suse.com>
Date: Mon, 1 Sep 2025 08:53:04 +0000 (+0100)
Subject: ARM: 9458/1: module: Ensure the override of module_arch_freeing_init()
X-Git-Tag: v6.17~1^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=44a375e8aaff360944606b3bb2df89f1376cbaf3;p=thirdparty%2Fkernel%2Fstable.git

ARM: 9458/1: module: Ensure the override of module_arch_freeing_init()

The function module_arch_freeing_init() defined in arch/arm/kernel/module.c
is supposed to override a weak function of the same name defined in
kernel/module/main.c. However, the ARM override is also marked as weak,
which means that selecting the correct function unnecessarily depends on
the order in which object files with both functions are passed to the

linker. Although it happens to be correct at the moment, the proper pattern
is to make the ARM override a strong definition.

Fixes: cdcb07e45a91 ("ARM: 8975/1: module: fix handling of unwind init sections")
Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---

diff --git a/arch/arm/kernel/module.c b/arch/arm/kernel/module.c
index da488d92e7a00..55ca3fcd37e86 100644
--- a/arch/arm/kernel/module.c
+++ b/arch/arm/kernel/module.c
@@ -484,7 +484,7 @@ module_arch_cleanup(struct module *mod)
 #endif
 }
 
-void __weak module_arch_freeing_init(struct module *mod)
+void module_arch_freeing_init(struct module *mod)
 {
 #ifdef CONFIG_ARM_UNWIND
 	struct unwind_table *init = mod->arch.init_table;