From: Paolo Bonzini <pbonzini@redhat.com>
Date: Wed, 14 Aug 2024 11:44:47 +0000 (+0200)
Subject: target/i386: add a note about gen_jcc1
X-Git-Tag: v9.2.0-rc0~27^2~12
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=44d58e938b649a3d73af9b12aba491ebc39e5f7c;p=thirdparty%2Fqemu.git

target/i386: add a note about gen_jcc1

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index 6e89d4faef1..5d729e68c98 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -1193,6 +1193,10 @@ static inline void gen_jcc1(DisasContext *s, int b, TCGLabel *l1)
 {
     CCPrepare cc = gen_prepare_cc(s, b, NULL);
 
+    /*
+     * Note that this must be _after_ gen_prepare_cc, because it
+     * can change the cc_op from CC_OP_DYNAMIC to CC_OP_EFLAGS!
+     */
     gen_update_cc_op(s);
     if (cc.use_reg2) {
         tcg_gen_brcond_tl(cc.cond, cc.reg, cc.reg2, l1);