From: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Date: Wed, 26 Jun 2024 22:25:27 +0000 (+0200)
Subject: pwm: Register debugfs operations after the pwm class
X-Git-Tag: v6.11-rc1~211^2~9
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=44ee95184e785c64e301498dec112bb1582bffd2;p=thirdparty%2Fkernel%2Flinux.git

pwm: Register debugfs operations after the pwm class

While the debugfs operations don't technically depend on an initialized
class, they loop over the idr that only can get entries when the class
is properly initialized.

This also fixes the ugly (but harmless) corner case that the debugfs
file stays around after the pwm class failed to initialize.

While at it, add an appropriate error message when class initialization
fails.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://lore.kernel.org/r/20240626222529.2901200-2-u.kleine-koenig@baylibre.com
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
---

diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 5c1d20985148c..84ca846120a25 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -1705,9 +1705,17 @@ DEFINE_SEQ_ATTRIBUTE(pwm_debugfs);
 
 static int __init pwm_init(void)
 {
+	int ret;
+
+	ret = class_register(&pwm_class);
+	if (ret) {
+		pr_err("Failed to initialize PWM class (%pe)\n", ERR_PTR(ret));
+		return ret;
+	}
+
 	if (IS_ENABLED(CONFIG_DEBUG_FS))
 		debugfs_create_file("pwm", 0444, NULL, NULL, &pwm_debugfs_fops);
 
-	return class_register(&pwm_class);
+	return 0;
 }
 subsys_initcall(pwm_init);