From: Thomas Weißschuh <thomas@t-8ch.de>
Date: Wed, 4 Oct 2023 15:21:47 +0000 (+0200)
Subject: Revert "libmount: (tab) avoid leaking memory allocated in loop"
X-Git-Tag: v2.40-rc1~214^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=44fa7b032e182fe8a58c699f64c3474ffa5f7abf;p=thirdparty%2Futil-linux.git

Revert "libmount: (tab) avoid leaking memory allocated in loop"

coverity claims that this is now a use-after-free.
Let's revert the original change and make the code clearer before trying
another fix.

This reverts commit d36306a560fd6d747e18ab22fc1279f4a373f43d.

Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
---

diff --git a/libmount/src/tab.c b/libmount/src/tab.c
index c6be5369e3..60bef8b2d1 100644
--- a/libmount/src/tab.c
+++ b/libmount/src/tab.c
@@ -1856,7 +1856,6 @@ int __mnt_table_is_fs_mounted(struct libmnt_table *tb, struct libmnt_fs *fstab_f
 				if (!*p)
 					tgt = tgt_prefix;	/* target is '/' */
 				else {
-					free(tgt_buf);
 					if (asprintf(&tgt_buf, "%s/%s", tgt_prefix, p) <= 0) {
 						rc = -ENOMEM;
 						goto done;