From: Jiri Olsa <jolsa@kernel.org>
Date: Mon, 7 Oct 2024 16:09:58 +0000 (+0200)
Subject: bpf: Fix memory leak in bpf_core_apply
X-Git-Tag: v6.12-rc4~18^2~25
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=45126b155e3b5201179cdc038504bf93a8ccd921;p=thirdparty%2Fkernel%2Flinux.git

bpf: Fix memory leak in bpf_core_apply

We need to free specs properly.

Fixes: 3d2786d65aaa ("bpf: correctly handle malformed BPF_CORE_TYPE_ID_LOCAL relos")
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Link: https://lore.kernel.org/bpf/20241007160958.607434-1-jolsa@kernel.org
---

diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
index 75e4fe83c5091..a05da5f435474 100644
--- a/kernel/bpf/btf.c
+++ b/kernel/bpf/btf.c
@@ -8961,6 +8961,7 @@ int bpf_core_apply(struct bpf_core_ctx *ctx, const struct bpf_core_relo *relo,
 	if (!type) {
 		bpf_log(ctx->log, "relo #%u: bad type id %u\n",
 			relo_idx, relo->type_id);
+		kfree(specs);
 		return -EINVAL;
 	}