From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: Tue, 24 Aug 2021 08:38:33 +0000 (+0300)
Subject: block/copy-before-write: drop extra bdrv_unref on failure path
X-Git-Tag: v6.2.0-rc0~121^2~25
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=451532311a6c37ac58794305c88307bd7c54526f;p=thirdparty%2Fqemu.git

block/copy-before-write: drop extra bdrv_unref on failure path

bdrv_attach_child() do bdrv_unref() on failure, so we shouldn't do it
by hand here.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210824083856.17408-12-vsementsov@virtuozzo.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
---

diff --git a/block/copy-before-write.c b/block/copy-before-write.c
index 2a51cc64e4a..945d9340f45 100644
--- a/block/copy-before-write.c
+++ b/block/copy-before-write.c
@@ -201,7 +201,6 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
     state->target = bdrv_attach_child(top, target, "target", &child_of_bds,
                                       BDRV_CHILD_DATA, errp);
     if (!state->target) {
-        bdrv_unref(target);
         bdrv_unref(top);
         return NULL;
     }