From: Willy Tarreau <w@1wt.eu>
Date: Thu, 24 Jan 2013 00:25:25 +0000 (+0100)
Subject: CLEANUP: http: remove a useless null check
X-Git-Tag: v1.5-dev18~116
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4521ba689c506ce66e4843c887fbc555d2ea2006;p=thirdparty%2Fhaproxy.git

CLEANUP: http: remove a useless null check

srv cannot be null in http_perform_server_redirect(), as it's taken
from the stream interface's target which is always valid for a
server-based redirect, and it was already dereferenced above, so in
practice, gcc already removes the test anyway.

Reported-by: Dinko Korunic <dkorunic@reflected.net>
---

diff --git a/src/proto_http.c b/src/proto_http.c
index 2a88fe0aca..3d68da89dd 100644
--- a/src/proto_http.c
+++ b/src/proto_http.c
@@ -817,8 +817,7 @@ void http_perform_server_redirect(struct session *s, struct stream_interface *si
 	http_server_error(s, si, SN_ERR_PRXCOND, SN_FINST_C, 302, &trash);
 
 	/* FIXME: we should increase a counter of redirects per server and per backend. */
-	if (srv)
-		srv_inc_sess_ctr(srv);
+	srv_inc_sess_ctr(srv);
 }
 
 /* Return the error message corresponding to si->err_type. It is assumed