From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon, 9 Apr 2012 15:59:17 +0000 (-0400)
Subject: Fix an Assert that turns out to be reachable after all.
X-Git-Tag: REL8_3_19~22
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=454c7fb3a372ef8970a3896dcec94efb6db41382;p=thirdparty%2Fpostgresql.git

Fix an Assert that turns out to be reachable after all.

estimate_num_groups() gets unhappy with
	create table empty();
	select * from empty except select * from empty e2;
I can't see any actual use-case for such a query (and the table is illegal
per SQL spec), but it seems like a good idea that it not cause an assert
failure.
---

diff --git a/src/backend/utils/adt/selfuncs.c b/src/backend/utils/adt/selfuncs.c
index 256a0725728..1455116ce9d 100644
--- a/src/backend/utils/adt/selfuncs.c
+++ b/src/backend/utils/adt/selfuncs.c
@@ -2616,8 +2616,13 @@ estimate_num_groups(PlannerInfo *root, List *groupExprs, double input_rows)
 	double		numdistinct;
 	ListCell   *l;
 
-	/* We should not be called unless query has GROUP BY (or DISTINCT) */
-	Assert(groupExprs != NIL);
+	/*
+	 * If no grouping columns, there's exactly one group.  (This can't happen
+	 * for normal cases with GROUP BY or DISTINCT, but it is possible for
+	 * corner cases with set operations.)
+	 */
+	if (groupExprs == NIL)
+		return 1.0;
 
 	/*
 	 * Count groups derived from boolean grouping expressions.  For other