From: Patrick Steinhardt Date: Thu, 18 Jan 2024 13:41:51 +0000 (+0100) Subject: reftable/stack: unconditionally reload stack after commit X-Git-Tag: v2.44.0-rc0~48^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=456333eb4d00a2bc8a71134bedfe5d3bc13a1932;p=thirdparty%2Fgit.git reftable/stack: unconditionally reload stack after commit After we have committed an addition to the reftable stack we call `reftable_stack_reload()` to reload the stack and thus reflect the changes that were just added. This function will only conditionally reload the stack in case `stack_uptodate()` tells us that the stack needs reloading. This check is wasteful though because we already know that the stack needs reloading. Call `reftable_stack_reload_maybe_reuse()` instead, which will unconditionally reload the stack. This is merely a conceptual fix, the code in question was not found to cause any problems in practice. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano --- diff --git a/reftable/stack.c b/reftable/stack.c index c28d82299d..705cfb6caa 100644 --- a/reftable/stack.c +++ b/reftable/stack.c @@ -585,7 +585,7 @@ int reftable_addition_commit(struct reftable_addition *add) add->new_tables = NULL; add->new_tables_len = 0; - err = reftable_stack_reload(add->stack); + err = reftable_stack_reload_maybe_reuse(add->stack, 1); if (err) goto done;