From: Rafael Ávila de Espíndola <rafael.espindola@gmail.com>
Date: Tue, 17 Feb 2015 15:43:20 +0000 (-0500)
Subject: Use std::upper_bound to simplify code a bit.
X-Git-Tag: gdb-7.10-branchpoint~1489
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=45a4fb1a700abeb4b3d8315b312ab31eee8efe72;p=thirdparty%2Fbinutils-gdb.git

Use std::upper_bound to simplify code a bit.

With std::upper_bound we don't have to check p->input_offset > input_offset.
---

diff --git a/gold/ChangeLog b/gold/ChangeLog
index f83c6524c8a..67efa5855d5 100644
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,3 +1,7 @@
+2015-02-17  Rafael Ávila de Espíndola <rafael.espindola@gmail.com>
+
+	* merge.cc (get_output_offset): Use upper_bound instead of lower_bound.
+
 2015-02-09  Mark Wielaard  <mjw@redhat.com>
 
 	* gdb-index.cc (Gdb_index_info_reader::visit_top_die): Recognize
diff --git a/gold/merge.cc b/gold/merge.cc
index f547388e308..bf004818119 100644
--- a/gold/merge.cc
+++ b/gold/merge.cc
@@ -162,15 +162,12 @@ Object_merge_map::get_output_offset(const Merge_map* merge_map,
   Input_merge_entry entry;
   entry.input_offset = input_offset;
   std::vector<Input_merge_entry>::const_iterator p =
-    std::lower_bound(map->entries.begin(), map->entries.end(),
+    std::upper_bound(map->entries.begin(), map->entries.end(),
 		     entry, Input_merge_compare());
-  if (p == map->entries.end() || p->input_offset > input_offset)
-    {
-      if (p == map->entries.begin())
-	return false;
-      --p;
-      gold_assert(p->input_offset <= input_offset);
-    }
+  if (p == map->entries.begin())
+    return false;
+  --p;
+  gold_assert(p->input_offset <= input_offset);
 
   if (input_offset - p->input_offset
       >= static_cast<section_offset_type>(p->length))