From: Filipe Manana <fdmanana@suse.com>
Date: Wed, 25 Feb 2026 19:22:41 +0000 (+0000)
Subject: btrfs: remove pointless error check in btrfs_check_dir_item_collision()
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=45cc960ff777ac9f4e57c896f1d01adc99fd696e;p=thirdparty%2Flinux.git

btrfs: remove pointless error check in btrfs_check_dir_item_collision()

We're under the IS_ERR() branch so we know that 'ret', which got assigned
the value of PTR_ERR(di) is always negative, so there's no point in
checking if it's negative.

Reviewed-by: Boris Burkov <boris@bur.io>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---

diff --git a/fs/btrfs/dir-item.c b/fs/btrfs/dir-item.c
index 085a83ae9e62..84f1c64423d3 100644
--- a/fs/btrfs/dir-item.c
+++ b/fs/btrfs/dir-item.c
@@ -253,9 +253,7 @@ int btrfs_check_dir_item_collision(struct btrfs_root *root, u64 dir_ino,
 		/* Nothing found, we're safe */
 		if (ret == -ENOENT)
 			return 0;
-
-		if (ret < 0)
-			return ret;
+		return ret;
 	}
 
 	/* we found an item, look for our name in the item */