From: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: Tue, 12 Mar 2024 14:13:41 +0000 (+0100)
Subject: qapi: Correct error message for 'vcpu_dirty_limit' parameter
X-Git-Tag: v9.1.0-rc0~141^2~2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=45d19d9306ade96404905aa89d534fc989ff9389;p=thirdparty%2Fqemu.git

qapi: Correct error message for 'vcpu_dirty_limit' parameter

QERR_INVALID_PARAMETER_VALUE is defined as:

  #define QERR_INVALID_PARAMETER_VALUE \
      "Parameter '%s' expects %s"

The current error is formatted as:

  "Parameter 'vcpu_dirty_limit' expects is invalid, it must greater then 1 MB/s"

Replace by:

  "Parameter 'vcpu_dirty_limit' must be greater than 1 MB/s"

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240312141343.3168265-9-armbru@redhat.com>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
[New error message corrected, commit message updated accordingly]
---

diff --git a/migration/options.c b/migration/options.c
index bfd7753b69a..d7a773aea8a 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -1286,9 +1286,8 @@ bool migrate_params_check(MigrationParameters *params, Error **errp)
 
     if (params->has_vcpu_dirty_limit &&
         (params->vcpu_dirty_limit < 1)) {
-        error_setg(errp, QERR_INVALID_PARAMETER_VALUE,
-                   "vcpu_dirty_limit",
-                   "is invalid, it must greater then 1 MB/s");
+        error_setg(errp,
+                   "Parameter 'vcpu_dirty_limit' must be greater than 1 MB/s");
         return false;
     }