From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Fri, 12 Jan 2024 10:22:06 +0000 (+0100)
Subject: 1524908 Use of auto that causes a copy
X-Git-Tag: dnsdist-1.9.0-rc1~36^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=463e41fccc251f5037b1d04b55051a8dca67d09c;p=thirdparty%2Fpdns.git

1524908 Use of auto that causes a copy
---

diff --git a/pdns/recursordist/rec-main.cc b/pdns/recursordist/rec-main.cc
index 54e6bc199f..173abc3ff2 100644
--- a/pdns/recursordist/rec-main.cc
+++ b/pdns/recursordist/rec-main.cc
@@ -583,7 +583,7 @@ void protobufLogResponse(const struct dnsheader* header, LocalStateHolder<LuaCon
   if (!luaconfsLocal->protobufExportConfig.logMappedFrom) {
     pbMessage.setSocketFamily(source.sin4.sin_family);
     Netmask requestorNM(source, source.sin4.sin_family == AF_INET ? luaconfsLocal->protobufMaskV4 : luaconfsLocal->protobufMaskV6);
-    auto requestor = requestorNM.getMaskedNetwork();
+    const auto& requestor = requestorNM.getMaskedNetwork();
     pbMessage.setFrom(requestor);
     pbMessage.setFromPort(source.getPort());
   }