From: Andrey Vatoropin <a.vatoropin@crpt.ru>
Date: Mon, 3 Mar 2025 09:13:56 +0000 (+0000)
Subject: fs/ntfs3: Drop redundant NULL check
X-Git-Tag: v6.16-rc1~140^2~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4665a0da497b1bd42569e5bc6da4cd9ce82f9c25;p=thirdparty%2Flinux.git

fs/ntfs3: Drop redundant NULL check

Static analysis shows that pointer "mi" cannot be NULL, since it is
pre-initialized above. A potential failure when mi equals NULL is
processed.

Remove the extra NULL check. It is meaningless and harms the readability
of the code, since before that the pointer is unconditionally
dereferenced.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Andrey Vatoropin <a.vatoropin@crpt.ru>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
---

diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c
index d0d530f4e2b95..e69f623b2e498 100644
--- a/fs/ntfs3/fslog.c
+++ b/fs/ntfs3/fslog.c
@@ -3143,7 +3143,7 @@ static int do_action(struct ntfs_log *log, struct OPEN_ATTR_ENRTY *oe,
 
 			if (inode)
 				iput(inode);
-			else if (mi)
+			else
 				mi_put(mi);
 
 			inode = inode_parent;