From: Hugo Landau <hlandau@openssl.org>
Date: Thu, 27 Jul 2023 15:17:33 +0000 (+0100)
Subject: QUIC APL: Add missing unlock call (coverity)
X-Git-Tag: openssl-3.2.0-alpha1~231
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4669a3d79b59d037ccb5b4a30bc522ebe55d3eec;p=thirdparty%2Fopenssl.git

QUIC APL: Add missing unlock call (coverity)

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/21565)
---

diff --git a/ssl/quic/quic_impl.c b/ssl/quic/quic_impl.c
index e285c66cb87..cf6233fc5b5 100644
--- a/ssl/quic/quic_impl.c
+++ b/ssl/quic/quic_impl.c
@@ -2565,9 +2565,11 @@ int ossl_quic_set_default_stream_mode(SSL *s, uint32_t mode)
 
     quic_lock(ctx.qc);
 
-    if (ctx.qc->default_xso_created)
+    if (ctx.qc->default_xso_created) {
+        quic_unlock(ctx.qc);
         return QUIC_RAISE_NON_NORMAL_ERROR(&ctx, ERR_R_SHOULD_NOT_HAVE_BEEN_CALLED,
                                            "too late to change default stream mode");
+    }
 
     switch (mode) {
     case SSL_DEFAULT_STREAM_MODE_NONE: