From: Jonathan Tan Date: Tue, 13 Feb 2018 18:39:38 +0000 (-0800) Subject: packfile: remove GIT_DEBUG_LOOKUP log statements X-Git-Tag: v2.17.0-rc0~62^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=4669e7d68ec8fb6ff3572a1193ae75ae2094b8e6;p=thirdparty%2Fgit.git packfile: remove GIT_DEBUG_LOOKUP log statements In commit 628522ec1439 ("sha1-lookup: more memory efficient search in sorted list of SHA-1", 2008-04-09), a different algorithm for searching a sorted list was introduced, together with a set of log statements guarded by GIT_DEBUG_LOOKUP that are invoked both when using that algorithm and when using the existing binary search. Those log statements was meant for experiments and debugging, but with the removal of the aforementioned different algorithm in commit f1068efefe6d ("sha1_file: drop experimental GIT_USE_LOOKUP search", 2017-08-09), those log statements are probably no longer necessary. Remove those statements. Signed-off-by: Jonathan Tan Signed-off-by: Junio C Hamano --- diff --git a/packfile.c b/packfile.c index 4a5fe7ab18..58bdced3b1 100644 --- a/packfile.c +++ b/packfile.c @@ -1713,10 +1713,6 @@ off_t find_pack_entry_one(const unsigned char *sha1, const uint32_t *level1_ofs = p->index_data; const unsigned char *index = p->index_data; unsigned hi, lo, stride; - static int debug_lookup = -1; - - if (debug_lookup < 0) - debug_lookup = !!getenv("GIT_DEBUG_LOOKUP"); if (!index) { if (open_pack_index(p)) @@ -1738,17 +1734,10 @@ off_t find_pack_entry_one(const unsigned char *sha1, index += 4; } - if (debug_lookup) - printf("%02x%02x%02x... lo %u hi %u nr %"PRIu32"\n", - sha1[0], sha1[1], sha1[2], lo, hi, p->num_objects); - while (lo < hi) { unsigned mi = lo + (hi - lo) / 2; int cmp = hashcmp(index + mi * stride, sha1); - if (debug_lookup) - printf("lo %u hi %u rg %u mi %u\n", - lo, hi, hi - lo, mi); if (!cmp) return nth_packed_object_offset(p, mi); if (cmp > 0)