From: Jouni Malinen Date: Mon, 17 Feb 2020 17:30:47 +0000 (+0200) Subject: nl80211: Check nla_nest_start() result for NL80211_ATTR_HE_OBSS_PD X-Git-Tag: hostap_2_10~1798 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=46cb046500e417a033001975661524f110d725eb;p=thirdparty%2Fhostap.git nl80211: Check nla_nest_start() result for NL80211_ATTR_HE_OBSS_PD nla_nest_start() might fail, so need to check its return value similarly to all the other callers. Fixes: a84bf443887d ("HE: Send the AP's OBSS PD settings to the kernel") Signed-off-by: Jouni Malinen --- diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c index 1421aff45..37933ae9a 100644 --- a/src/drivers/driver_nl80211.c +++ b/src/drivers/driver_nl80211.c @@ -4353,7 +4353,8 @@ static int wpa_driver_nl80211_set_ap(void *priv, spr = nla_nest_start(msg, NL80211_ATTR_HE_OBSS_PD); wpa_printf(MSG_DEBUG, "nl80211: he_spr=%d", params->he_spr); - if (nla_put_u8(msg, NL80211_HE_OBSS_PD_ATTR_MIN_OFFSET, + if (!spr || + nla_put_u8(msg, NL80211_HE_OBSS_PD_ATTR_MIN_OFFSET, params->he_spr_srg_obss_pd_min_offset) || nla_put_u8(msg, NL80211_HE_OBSS_PD_ATTR_MAX_OFFSET, params->he_spr_srg_obss_pd_max_offset))