From: Willy Tarreau <w@1wt.eu>
Date: Tue, 23 Jan 2018 18:20:19 +0000 (+0100)
Subject: BUG/MINOR: mworker: only write to pidfile if it exists
X-Git-Tag: v1.9-dev1~500
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=46ec48bc1ad81cdf10aacfd5d7b2911c0ef2b0df;p=thirdparty%2Fhaproxy.git

BUG/MINOR: mworker: only write to pidfile if it exists

A missing test causes a write(-1, $PID) to appear in strace output when
in master-worker mode. This is totally harmless though.

This fix must be backported to 1.8.
---

diff --git a/src/haproxy.c b/src/haproxy.c
index 89044c6a5d..8e0e30d8a4 100644
--- a/src/haproxy.c
+++ b/src/haproxy.c
@@ -2786,7 +2786,8 @@ int main(int argc, char **argv)
 		if (global.mode & MODE_MWORKER) {
 			char pidstr[100];
 			snprintf(pidstr, sizeof(pidstr), "%d\n", getpid());
-			shut_your_big_mouth_gcc(write(pidfd, pidstr, strlen(pidstr)));
+			if (pidfd >= 0)
+				shut_your_big_mouth_gcc(write(pidfd, pidstr, strlen(pidstr)));
 		}
 
 		/* the father launches the required number of processes */