From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Sun, 5 May 2019 14:55:06 +0000 (+0200)
Subject: efi_loader: LoadImage() check source size
X-Git-Tag: v2019.07-rc2~15^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=470dfa50da799720ed6513b89b9237064415cb73;p=thirdparty%2Fu-boot.git

efi_loader: LoadImage() check source size

If the size of the source buffer is 0, return EFI_LOAD_ERROR.
(UEFI SCT II 2017: 3.4.1 LoadImage() - 5.1.4.1.6)

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---

diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
index ef9e3781899..89966a2f129 100644
--- a/lib/efi_loader/efi_boottime.c
+++ b/lib/efi_loader/efi_boottime.c
@@ -1781,6 +1781,10 @@ efi_status_t EFIAPI efi_load_image(bool boot_policy,
 		if (ret != EFI_SUCCESS)
 			goto error;
 	} else {
+		if (!source_size) {
+			ret = EFI_LOAD_ERROR;
+			goto error;
+		}
 		dest_buffer = source_buffer;
 	}
 	/* split file_path which contains both the device and file parts */