From: Tom de Vries <tdevries@suse.de>
Date: Mon, 11 Oct 2021 10:21:00 +0000 (+0200)
Subject: [gdb/testsuite] Fix gdb.dwarf2/gdb-add-index-symlink.exp
X-Git-Tag: binutils-2_38~1166
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=47265957ad9b1de1d6434baa0569d286d75eaf48;p=thirdparty%2Fbinutils-gdb.git

[gdb/testsuite] Fix gdb.dwarf2/gdb-add-index-symlink.exp

The test-case gdb.dwarf2/gdb-add-index-symlink.exp interpretes a failure to
add an index as a failure to add an index for a symlink:
...
if { [ensure_gdb_index $symlink] == -1 } {
    fail "Unable to call gdb-add-index with a symlink to a symfile"
    return -1
}
...

However, it's possible that the gdb-add-index also fails with a regular
file.  Add a check for that situation.

Tested on x86_64-linux.
---

diff --git a/gdb/testsuite/gdb.dwarf2/gdb-add-index-symlink.exp b/gdb/testsuite/gdb.dwarf2/gdb-add-index-symlink.exp
index eaeddec0250..74c558ad231 100644
--- a/gdb/testsuite/gdb.dwarf2/gdb-add-index-symlink.exp
+++ b/gdb/testsuite/gdb.dwarf2/gdb-add-index-symlink.exp
@@ -22,6 +22,19 @@ if {![dwarf2_support]} {
 
 standard_testfile main.c
 
+# First check whether we can actually handle the non-symlink case.
+with_test_prefix non-symlink {
+    if { [prepare_for_testing "failed to prepare" "${testfile}" \
+	      [list ${srcfile}]] } {
+	return -1
+    }
+
+    if { [ensure_gdb_index $binfile] == -1 } {
+	return -1
+    }
+}
+
+# Regenerate exec without index.
 if { [prepare_for_testing "failed to prepare" "${testfile}" \
 	  [list ${srcfile}]] } {
     return -1