From: Shameer Kolothum Date: Tue, 8 Jul 2025 15:40:44 +0000 (+0100) Subject: hw/arm/virt-acpi-build: Don't create ITS id mappings by default X-Git-Tag: v10.1.0-rc0~26^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=47a4f6a900e1d0764cb973b7140f471859de4128;p=thirdparty%2Fqemu.git hw/arm/virt-acpi-build: Don't create ITS id mappings by default Commit d6afe18b7242 ("hw/arm/virt-acpi-build: Fix ACPI IORT and MADT tables when its=off") moved ITS group node generation under the its=on condition. However, it still creates rc_its_idmaps unconditionally, which results in duplicate ID mappings in the IORT table. Fixes:d6afe18b7242 ("hw/arm/virt-acpi-build: Fix ACPI IORT and MADT tables when its=off") Reviewed-by: Jonathan Cameron Reviewed-by: Eric Auger Reviewed-by: Donald Dutile Tested-by: Eric Auger Signed-off-by: Shameer Kolothum Signed-off-by: Peter Maydell --- diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index c3b9b3f6ea..0dfb8ec2c3 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -358,12 +358,6 @@ build_iort(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) /* Sort the smmu idmap by input_base */ g_array_sort(rc_smmu_idmaps, iort_idmap_compare); - /* - * Knowing the ID ranges from the RC to the SMMU, it's possible to - * determine the ID ranges from RC that are directed to the ITS. - */ - create_rc_its_idmaps(rc_its_idmaps, rc_smmu_idmaps); - nb_nodes = 2; /* RC and SMMUv3 */ rc_mapping_count = rc_smmu_idmaps->len;