From: Andrew Bartlett <abartlet@samba.org>
Date: Sun, 23 Feb 2020 21:30:26 +0000 (+1300)
Subject: dsdb: Improve clarity by adding a comment in replmd_delete_internals()
X-Git-Tag: ldb-2.2.0~1541
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=47b6c4b8f5987adda861bf8440949df4aaacef6c;p=thirdparty%2Fsamba.git

dsdb: Improve clarity by adding a comment in replmd_delete_internals()

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
index 3395e6395ac..824a4612f5a 100644
--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
@@ -4664,6 +4664,11 @@ static int replmd_delete_internals(struct ldb_module *module, struct ldb_request
 						      el->name,
 						      ldb_attr_cmp,
 						      attr);
+				/*
+				 * If we are preserving, do not do the
+				 * ldb_msg_add_empty() below, continue
+				 * to the next element
+				 */
 				if (attr != NULL) {
 					continue;
 				}