From: Pedro Alves <palves@redhat.com>
Date: Thu, 8 Aug 2013 17:00:42 +0000 (+0000)
Subject: gcore: expand tilde in filename.
X-Git-Tag: binutils-2_24-branchpoint~318
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=47ecca85db40d34820d94fbc5fb79babaa95b725;p=thirdparty%2Fbinutils-gdb.git

gcore: expand tilde in filename.

Before this patch, this fails:

 (gdb) generate-core-file ~/core
 Failed to open '~/core' for output.

After the patch:

 (gdb) generate-core-file ~/core
 Saved corefile ~/core

gdb/
2013-08-08  Azat Khuzhin  <a3at.mail@gmail.com>  (tiny change)

	* gcore.c (create_gcore_bfd): Use tilde_expand.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3de17da9231..13a9ccdaba5 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2013-08-08  Azat Khuzhin  <a3at.mail@gmail.com>  (tiny change)
+
+	* gcore.c (create_gcore_bfd): Use tilde_expand.
+
 2013-08-08  Yao Qi  <yao@codesourcery.com>
 
 	* frame.h (read_frame_local): Declare.
diff --git a/gdb/gcore.c b/gdb/gcore.c
index 620be54dd99..9c83ec82f89 100644
--- a/gdb/gcore.c
+++ b/gdb/gcore.c
@@ -34,6 +34,7 @@
 #include "regcache.h"
 #include "regset.h"
 #include "gdb_bfd.h"
+#include "readline/tilde.h"
 
 /* The largest amount of memory to read from the target at once.  We
    must throttle it to limit the amount of memory used by GDB during
@@ -51,7 +52,12 @@ static int gcore_memory_sections (bfd *);
 bfd *
 create_gcore_bfd (const char *filename)
 {
-  bfd *obfd = gdb_bfd_openw (filename, default_gcore_target ());
+  char *fullname;
+  bfd *obfd;
+
+  fullname = tilde_expand (filename);
+  obfd = gdb_bfd_openw (fullname, default_gcore_target ());
+  xfree (fullname);
 
   if (!obfd)
     error (_("Failed to open '%s' for output."), filename);