From: Phil Sutter <phil@nwl.cc>
Date: Wed, 19 Sep 2018 13:17:02 +0000 (+0200)
Subject: nft-arp: Drop ineffective conditional
X-Git-Tag: v1.8.1~21
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=47fb86cef5f4da6ee86100e410212b7b54e4800c;p=thirdparty%2Fiptables.git

nft-arp: Drop ineffective conditional

Since fw->arp.arhln is of type __u8, its value will never become less
than zero.

Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Florian Westphal <fw@strlen.de>
---

diff --git a/iptables/nft-arp.c b/iptables/nft-arp.c
index 7332b619..b8e89826 100644
--- a/iptables/nft-arp.c
+++ b/iptables/nft-arp.c
@@ -330,9 +330,6 @@ static void nft_arp_parse_payload(struct nft_xt_ctx *ctx,
 			fw->arp.invflags |= ARPT_INV_ARPOP;
 		break;
 	default:
-		if (fw->arp.arhln < 0)
-			break;
-
 		if (ctx->payload.offset == sizeof(struct arphdr) +
 					   fw->arp.arhln) {
 			get_cmp_data(e, &addr, sizeof(addr), &inv);